New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Made selector return types generic #1688

Merged

bmingles merged 2 commits into deephaven:main from bmingles:1687-selector-types

Dec 12, 2023

Contributor

bmingles commented Dec 12, 2023

fixes #1687


          Made selector return types generic

fd4854e

deephaven#1687

bmingles requested a review from mofojed

December 12, 2023 15:13


          Fixed imports

2d8a521

deephaven#1687

mofojed approved these changes

View reviewed changes

packages/utils/src/TypeUtils.ts

+               * than `Required` because it will preserve optional properties on the original
+               * target type.
+               */
+              export type UndoPartial<T> = T extends Partial<infer U> ? U : never;

Member

mofojed Dec 12, 2023

Ohh neat

bmingles merged commit b2972f0 into deephaven:main

4 checks passed

bmingles deleted the 1687-selector-types branch

December 12, 2023 17:04

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet